Shipping Method Bug

Posted By BORNXenon Wed 11 Jun 2014
Add to Favorites0
Author Message
BORNXenon
 Posted Wed 11 Jun 2014
Supreme Being

Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)

Group: Forum Members
Last Active: Mon 23 Apr 2018
Posts: 59, Visits: 291
Not really a bug, more an issue with the delimiter chosen for the shipping methods array.

In 'ShippingMethodsDropdown.ascx.vb' on in the Refresh() function on line 65 there is the following code:


Dim arrText As String() = Split(liShippingMethod.Text, ":")



Now the problem with this is that it is looking for the ':' in the array to which is used to separate the array values, this would ordinarily be ok, but consider this, a shop owner uses a courier company that provides various services that the shop owner would like to offer to his customers, specifically the Pre-10:30am delivery service.


See the problem? The array is configured with ':' as the delimiter, Mr shop owner has put his Pre-10:30am delivery service in as a shipping option, all of a sudden, order check out is broken throwing the error
Conversion from string "30am delivery" to type 'Double' is not valid
because the array is splitting prematurely and the following code is expecting a numerical value, not a string value.

Could this be changed in the next version, maybe to the '|||' delimiter that is used extensively elsewhere in the code?

Cheers

Chris
BORNXenon
 Posted Wed 11 Jun 2014
Supreme Being

Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)Supreme Being - (34,953 reputation)

Group: Forum Members
Last Active: Mon 23 Apr 2018
Posts: 59, Visits: 291
Ok, I know why it is using ':' as separator, it is because hidden away in the Helpers.vb Class, xhtmlConformance mode="Legacy" is added to the web.config.

Is there a reason legacy mode is preferred? I thought Legacy mode caused issues with Update Panels and the like?

Similar Topics

Expand / Collapse

Reading This Topic

Expand / Collapse

Back To Top